Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical ZQ1 blocks should have their state root hash set to zero #2054

Open
JamesHinshelwood opened this issue Dec 20, 2024 · 3 comments
Open
Labels
Agate Required for mainnet launch

Comments

@JamesHinshelwood
Copy link
Contributor

We don't know the state for these blocks, so lets not pretend we do.

@DrZoltanFazekas DrZoltanFazekas added the Agate Required for mainnet launch label Jan 7, 2025
@JamesHinshelwood
Copy link
Contributor Author

Also we shouldn't try to execute transactions against these 'null' states. The results are meaningless and waste our time.

@DrZoltanFazekas
Copy link
Contributor

Agree, eth_call and eth_estimateGas shall also not try to execute code on the unknown state of old ZQ1 blocks

@86667
Copy link
Contributor

86667 commented Jan 15, 2025

We are seeing a lot of API node crashes at the moment which I believe could be fixed in this ticket. As well as zeroing the state root for ZQ1 blocks we should also fix such that balance checks in block trace re-executions do not throw. Details:

API calls ots_getInternalOperations and ots_traceTransaction often throw insufficient balance: zilliqa/src/exec.rs:1938:49 which causes an unwrap() on PoisonError.

For an example, search protontestnet API node logs for ERROR logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agate Required for mainnet launch
Projects
None yet
Development

No branches or pull requests

3 participants