From 17a96d5e594302b4fbecf85fade3fbb04c59178e Mon Sep 17 00:00:00 2001 From: Lucas PASCAL Date: Tue, 5 Jul 2022 17:37:47 +0200 Subject: [PATCH 1/3] [ci][add] Triggering CI on main&develop PRs --- .github/workflows/ledger.yml | 8 ++++++-- .github/workflows/main.yml | 11 ++++++++++- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ledger.yml b/.github/workflows/ledger.yml index bedf8b8..8a60acf 100644 --- a/.github/workflows/ledger.yml +++ b/.github/workflows/ledger.yml @@ -3,9 +3,13 @@ name: CI on: # Triggers the workflow on push or pull request events but only for the main branch push: - branches: [ main ] + branches: + - main + - develop pull_request: - branches: [ main ] + branches: + - main + - develop # Allows you to run this workflow manually from the Actions tab workflow_dispatch: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c987097..2b8b438 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,5 +1,14 @@ name: Build -on: [ push ] +on: + push: + branches: + - main + - develop + pull_request: + branches: + - main + - develop + jobs: configure: From fe3d7a1c65d21aff2871ba02885f95970d4521b5 Mon Sep 17 00:00:00 2001 From: Lucas PASCAL Date: Tue, 26 Jul 2022 13:38:46 +0200 Subject: [PATCH 2/3] [add] PENDING_REVIEW flag --- app/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/Makefile b/app/Makefile index 161548b..e1206dc 100755 --- a/app/Makefile +++ b/app/Makefile @@ -87,7 +87,6 @@ APPPATH = "44'/1003'" --path "44'/354'" else define error_message - COIN value not supported: [$(COIN)] @@ -97,6 +96,9 @@ endif APP_LOAD_PARAMS = --curve ed25519 $(COMMON_LOAD_PARAMS) --path $(APPPATH) +APP_LOAD_PARAMS += --tlvraw 9F:01 +DEFINES += HAVE_PENDING_REVIEW_SCREEN + ifeq ($(TARGET_NAME),TARGET_NANOS) APP_LOAD_PARAMS += --appFlags 0x000 APP_STACK_SIZE:=3216 From e4c0873f59f1d8c4954e5e9b7f48f5074f581eed Mon Sep 17 00:00:00 2001 From: Lucas PASCAL Date: Wed, 21 Sep 2022 15:03:18 +0200 Subject: [PATCH 3/3] Revert "[add] PENDING_REVIEW flag" This reverts commit fe3d7a1c65d21aff2871ba02885f95970d4521b5. --- app/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/Makefile b/app/Makefile index e1206dc..161548b 100755 --- a/app/Makefile +++ b/app/Makefile @@ -87,6 +87,7 @@ APPPATH = "44'/1003'" --path "44'/354'" else define error_message + COIN value not supported: [$(COIN)] @@ -96,9 +97,6 @@ endif APP_LOAD_PARAMS = --curve ed25519 $(COMMON_LOAD_PARAMS) --path $(APPPATH) -APP_LOAD_PARAMS += --tlvraw 9F:01 -DEFINES += HAVE_PENDING_REVIEW_SCREEN - ifeq ($(TARGET_NAME),TARGET_NANOS) APP_LOAD_PARAMS += --appFlags 0x000 APP_STACK_SIZE:=3216