Eliminated heap #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serges147
commented
Aug 24, 2024
serges147
commented
Aug 24, 2024
serges147
commented
Aug 24, 2024
pavel-kirienko
approved these changes
Aug 26, 2024
include/olg_scheduler/scheduler.hpp
Outdated
There was a problem hiding this comment.
Maybe we should call this file include/olg_scheduler/olg_scheduler.hpp then? I am pretty confident this little library is going to stay single-header only.
include/olg_scheduler/scheduler.hpp
Outdated
| @@ -18,12 +18,12 @@ | |||
| #pragma once | |||
|
|
|||
| #include <cavl/cavl.hpp> | |||
There was a problem hiding this comment.
The idiomatic inclusion pattern for cavl is just cavl.hpp. The current form will break if the user decided to submodule the cavl repo. The include path settings will need to be adjusted.
Suggested change
| #include <cavl/cavl.hpp> | |
| #include <cavl.hpp> |
|
Please transfer the repository to Zubax afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that events are not (yet) move assignable - possible to address, but will see do we need it actually. Implementation of such feature will make current design a bit more complex (b/c lambdas are not move assignable as soon as there is non-empty capture list (it does not matter, by value, by reference, or even dummy
[&]without actual referencing of anything) - only explicitly empty[]guarantees that lambda is move assignable.