Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositeAudioClip not compute duration #2209

Closed
CorrM opened this issue Aug 2, 2024 · 1 comment
Closed

CompositeAudioClip not compute duration #2209

CorrM opened this issue Aug 2, 2024 · 1 comment
Labels
audio Related to AudioClip, or handling of audio in general. bug Issues that report (apparent) bugs. documentation Related to documentation in official project docs or individual docstrings.

Comments

@CorrM
Copy link

CorrM commented Aug 2, 2024

The __init__ function should look something like that:

        if not any([(e is None) for e in ends]):
            self.duration = max(ends)
            self.end = max(ends)
        elif not any([(d is None) for d in [c.duration for c in self.clips]]):
            self.duration = max([c.duration for c in self.clips])
            self.end = self.duration

because the docs for clips are:

clips
      List of audio clips, which may start playing at different times or
      together. If all have their ``duration`` attribute set, the
      duration of the composite clip is computed automatically.
@CorrM CorrM added the bug Issues that report (apparent) bugs. label Aug 2, 2024
@keikoro keikoro added documentation Related to documentation in official project docs or individual docstrings. audio Related to AudioClip, or handling of audio in general. labels Dec 8, 2024
@OsaAjani
Copy link
Collaborator

Thank you for your contributions and for reporting issues in this repository. With the release of v2, which introduces significant changes to the codebase and API, we’ve reviewed the backlog of open PRs and issues. Due to the length of the backlog and the likelihood that many of these are either fixed or no longer applicable, we’ve made the decision to close all previous PRs and issues.

If you believe that any of these are still relevant to the current version or if you'd like to reopen a related discussion, please feel free to create a new issue or pull request, referencing the old one.

Thank you for your understanding and continued support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio Related to AudioClip, or handling of audio in general. bug Issues that report (apparent) bugs. documentation Related to documentation in official project docs or individual docstrings.
Projects
None yet
Development

No branches or pull requests

3 participants