-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cancelling with CTRL+C need to be followed by umount /run/bees/mnt/$UUID #281
Comments
@Zygo would be nice if bees was fixing itself on die |
Putting this at the beginning of beesd should work:
The drawback is that this duplicates the systemd namespacing, and requires the namespace privilege in the script to work. Maybe some additional checks to see if it's running under systemd and skip the extra |
Hi, is this going to be fixed in the release? |
@Zygo I still think this should be managed by code in testing version, prior of next release. |
Detecting if a service is running under systemd is easy by looking at the environment variables. I can create a PR for that. |
@kakra please do! |
Please do! |
If starting the beesd script without systemd, the mount point won't automatically unmount if the script is cancelled with ctrl+c. Fixes: Zygo#281 Signed-off-by: Kai Krakow <[email protected]>
I've added an untested PR using @Zygo's idea, please check if it works properly. |
It looks good, but it needs testing on the weird distros. It'll fail outright if you don't have I'm also looking at adding |
I cherry-picked kakra's PR and accidentally closed this (but not the PR). Yay github surprise UI. At this point the original issue should be solved. If there are new issues, please reopen. |
Originally posted by @Massimo-B in #54 (comment)
Confirmed on 1245072 from 9 months ago
The text was updated successfully, but these errors were encountered: