Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Incorrect filter method names #443

Closed
eshaan7 opened this issue Nov 22, 2024 · 3 comments · Fixed by #450
Closed

[bug] Incorrect filter method names #443

eshaan7 opened this issue Nov 22, 2024 · 3 comments · Fixed by #450

Comments

@eshaan7
Copy link
Contributor

eshaan7 commented Nov 22, 2024

The following 3 method names are incorrect:
image

As per the spec, these should be eth_newFilter, eth_newBlockFilter and eth_newPendingTransactionFilter respectively:

image

Also, these 3 methods seem to be missing corresponding Wasm bindings. Is that intended?

@eshaan7 eshaan7 changed the title Incorect filter method names [bug] Incorrect filter method names Nov 23, 2024
@ncitron
Copy link
Collaborator

ncitron commented Nov 25, 2024

Ah good catch. We should change this and make sure the names in the Client/Node objects are also made to align with the jsonrpc names for consistency. And yes lets add these methods to the wasm binding as well.

@eshaan7
Copy link
Contributor Author

eshaan7 commented Nov 25, 2024

Raised PR #450 removing the incorrect get prefix from these 3 methods. This is technically a breaking change btw.

@eshaan7
Copy link
Contributor Author

eshaan7 commented Nov 25, 2024

Will be raising a separate PR for the Wasm bindings because that is missing for few other methods beyond these 3. Tracking in #451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants