Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up several minor issues in setPage #19

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aarongoldenthal
Copy link
Owner

@aarongoldenthal aarongoldenthal commented Mar 29, 2024

The following issues were noticed today in the setPage function (all are low priority cleanup).

  • Removed unused url argument from setPage
  • Moved debug log entry for navigating to URL to proper location (from setPage to gotoUrl)
  • Update debug logging for all setPage operations

Debug log changes:

 > pa11y -d https://pa11y.org

 Welcome to Pa11y

  > Running Pa11y on URL https://pa11y.org
  > Debug: Launching Headless Chrome
- > Debug: Opening URL in Headless Chrome
+ > Debug: Opening new browser page
+ > Debug: Setting page User-Agent to "pa11y/8.0.0"
+ > Debug: Setting page viewport
+ > Debug: Navigating to https://pa11y.org
  > Debug: Loading runner: htmlcs
  > Debug: Injecting Pa11y
  > Debug: Injecting runner: htmlcs
  > Debug: Running Pa11y on the page
  > Debug: Document title: "Pa11y"

 No issues found!

@aarongoldenthal aarongoldenthal added the open work Additional work is required before merging label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open work Additional work is required before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant