Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically compile Import does not work properly on Windows #115

Open
JimmyZJX opened this issue Jan 15, 2019 · 5 comments
Open

Automatically compile Import does not work properly on Windows #115

JimmyZJX opened this issue Jan 15, 2019 · 5 comments

Comments

@JimmyZJX
Copy link

When the file is located in a directory with space in it, say "C:\Google Drive", the auto compile does not work properly. Error information like "Error: Multiple files specified as input" is shown.

@chaudhuri
Copy link
Member

Can you run it from a directory without spaces for the time being? Our treatment of filenames is not very portable at the moment.

@JimmyZJX
Copy link
Author

Sure. No big deal. Looking forward to the fix :)

@chaudhuri
Copy link
Member

Jimmy, can you try out the master branch to see if the problem is fixed? I've done some light testing with a Windows 10 VM and it seems to work with directories containing spaces, but I don't know if that was the entirety of the problem. I tried it with a mingw64 cross-compiled binary from Linux -- if you compile Abella yourself in Windows you may have a different experience of which I would be curious to learn.

@JimmyZJX
Copy link
Author

JimmyZJX commented Jan 17, 2019

I just tested with my environment (Cygwin32+OCaml). It seems that the quote is correctly added, but there is another issue: filenames are escaped one more time per resursion. A log may look like this:

Importing from "C:\\Users\\Jimmy\\Google Drive\\decidability".
Warning: "C:\\Users\\Jimmy\\Google Drive\\decidability.thc" was compiled with a different version (2.0.7-dev) of Abella; recompiling...
Running: abella "C:\\Users\\Jimmy\\Google Drive\\decidability.thm" -o "C:\\Users\\Jimmy\\Google Drive\\decidability".out -c "C:\\Users\\Jimmy\\Google Drive\\decidability.thc".
Warning: "C:\\\\Users\\\\Jimmy\\\\Google Drive\\decidability_inst.thc" was compiled with a different version (2.0.7-dev) of Abella; recompiling...
Running: abella "C:\\\\Users\\\\Jimmy\\\\Google Drive\\decidability_inst.thm" -o "C:\\\\Users\\\\Jimmy\\\\Google Drive\\decidability_inst".out -c "C:\\\\Users\\\\Jimmy\\\\Google Drive\\decidability_inst.thc".
...
Error: Could not create "C:\\\\\\\\\\\\\\\\Users\\\\\\\\\\\\\\\\Jimmy\\\\\\\\\\\\\\\\Google Drive...

But I've tested when the dependency chain is short. Seems like when too many '\' characters occur in the path, Windows just give up lol

@chaudhuri
Copy link
Member

Wow. OK, I clearly need to test more thoroughly. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants