Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that LlamaSamplingContext is no longer in use. #1866

Open
Taiki-azrs opened this issue Dec 16, 2024 · 0 comments
Open

It seems that LlamaSamplingContext is no longer in use. #1866

Taiki-azrs opened this issue Dec 16, 2024 · 0 comments

Comments

@Taiki-azrs
Copy link

LlamaSamplingContext is not referenced anywhere, and functions like llama_sample_top_k from llama.cpp also seem to be incompatible now. Is there any specific reason to keep these in the codebase? If not needed, I think it would be better to remove them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Taiki-azrs