Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EXCLUDED_ARCHS entry from pods post_install script #40

Closed
mmiedlarz opened this issue Dec 16, 2020 · 3 comments
Closed

Remove EXCLUDED_ARCHS entry from pods post_install script #40

mmiedlarz opened this issue Dec 16, 2020 · 3 comments
Assignees
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@mmiedlarz
Copy link
Contributor

mmiedlarz commented Dec 16, 2020

There is a MapBox issue which forced us to add the following post_install hook to be able to run example app on physical device:

post_install do |installer|
  installer.pods_project.build_configurations.each do |config|
    config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64'
  end
end

The issue here is that it will cause the build to fail on the iOS simulator when compiled on Mac with M1 CPU.
So far it's not a huge problem, but we need to fix it as soon as the MapBox team releases the new framework version.

@mmiedlarz mmiedlarz added invalid and removed invalid labels Dec 16, 2020
@QuintinWillison
Copy link
Contributor

Also commented on by me in Slack.

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Mar 25, 2021

This issue should end up being obsoleted by #106.

@QuintinWillison QuintinWillison added the code-quality Affects the developer experience when working in our codebase. label Mar 25, 2021
@ben-xD
Copy link
Contributor

ben-xD commented May 26, 2021

This issue should end up being obsoleted by #106.

Closing because I upgraded to mapbox navigation v2.0, tested everything is working without the workarounds (excluded_archs). #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Affects the developer experience when working in our codebase.
Development

No branches or pull requests

4 participants