-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distro is passed as None for RPM packages #3443
Comments
Hey @TG1999 , did you mean handle "None" value for 'distro' or set a default value to distro? |
See also Input PURL does not match output PURL #1274, just added a few minutes ago. |
A rough idea from my side . what you think @TG1999 . |
Some hints for solving this:
|
Don't we have the same/similar problem for redhat, fedora or centos for type=rpm? We need some well-documented default in all cases |
Yes! The issue exists with RPMs too |
This is fixed for debian by the following PRs:
We need to do something similar for RPM. |
For RPMs, the same thing to do is IMHO to use the /etc/os-release "identifier" field ( as in |
Update debian, rpm and alpine package assembly to get distro identifier and then set this properly to created package, dependency and package_uid instances. Reference: #3443 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Description
For debian based packages we pass namespace=distro here https://github.com/nexB/scancode-toolkit/blob/8ed266372416a4e55cf739dadafa175214dca980/src/packagedcode/debian.py#L634 but never passes distro apart from the case where it's distroless.
How To Reproduce
Look at the issue details
The text was updated successfully, but these errors were encountered: