-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Office 365 Gov Cloud #937
Comments
@spinkernel What client version are you running ? |
Oh I should have put that. Will update shortly.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: abraunegg <[email protected]>
Sent: Thursday, May 28, 2020 1:56:10 PM
To: abraunegg/onedrive <[email protected]>
Cc: Dustin Sanders <[email protected]>; Mention <[email protected]>
Subject: Re: [abraunegg/onedrive] Support Office 365 Gov Cloud (#937)
@spinkernel<https://github.com/spinkernel>
The client output is not correct.
What client version are you running ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#937 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALLRGW3WMTEZ67C3T32WKM3RT3FWVANCNFSM4NNNKLCQ>.
|
onedrive v2.3.13-1build2 I just built the latest (2.4.2), i did get slightly different results:
|
@spinkernel |
@spinkernel
This is because the application itself does not know, that for US Gov, it should use different authentication / query URL's - thus it currently does not support National Azure AD endpoints as per https://docs.microsoft.com/en-us/graph/deployments - and it only supports the 'Global Service' Currently writing a PR for you to test that will provide this functionality. I have however zero capability to test this, other than ensuring that the client passes the right URL's ... so this will require you do perform debug testing. |
Happy to test whatever, I figured this is what would happen, didn't expect such quick responses! I'm keeping network engineer in the loop too as he's interested. I'm the only developer and linux user in the company. |
@spinkernel
You will need to add the following into your config file as well:
Where the following are valid options:
Example:
Example output:
Note: This is what I expect for me ... as I do not have a valid login / credentials. I am only going to test that once as per above. |
Thanks!
But i got this in the web sign in page not in onedrive output. |
@spinkernel Before I go changing the application registration, can you, as a test, follow the directions listed here: This will register you a new application against your Azure AD instance. When selecting the redirect URI, select Public client / native as per below: Once you have your new client id, add this to your config file as per:
If then that is working correctly, I can then add the expected response URI to the main / default application ID, negating the need to register a new application ID all the time. |
@spinkernel |
I'm waiting for approval from my IT Dept. Thanks! |
@spinkernel AFAIK there is no cert / data exchange in this process. If this will be too difficult, I can just add the URL's to the current application ID - however unsure if that will 'break' for all other users .... |
@spinkernel |
No difficulty its just satisfying paranoia. You're team does not have any servers which this application ID references or transmits data to correct? That's all that needs to be known. After that we can press forward. |
@spinkernel Feel free to reach out to me offline if you need me to have a chat with anyone. |
@spinkernel
Azure AD fails to add these, as these are prohibited domains: So the only way that this will work is:
Will have to get this correctly documented, however have no real way to test / validate the steps / process if not using a 'global' Azure AD instance. |
@spinkernel |
@spinkernel |
@spinkernel |
1 similar comment
@spinkernel |
@abraunegg |
@spinkernel |
@abraunegg As for the test, things went will until the end:
Also updated the branch to the latest, same issue.
|
If you can submit the required changes / any new images to update the documentation that would be greatly appreciated - as I have no way to validate this at all. However .. this issue is going to be a bigger challenge:
Based on https://docs.microsoft.com/en-us/graph/deployments#supported-features despite the OneDrive graph feature being available (which I was hoping on being fully supported), the 'Delta query' looks like this has been 'disabled', thus the delta queries (basically tracking 'what changed' on OneDrive) is not possible - which is how the client works today. What this means is, that when National Cloud Deployments is used, the query that tells the client what files are on OneDrive needs to be updated. Question: How quickly are you able to respond to code changes / development updates? I am cognitive of TZ differences here, and because of clearance requirements - so no way to send data beyond what you have above. Basically - what I need to do is create a new function that looks at the children of the drive rather than the delta - then that 'may' work, but then run into another issue to solve. What are your thoughts here in assisting? |
@abraunegg I'm happy to test new builds and so is he. I suspect these alternative methods could be tested with the global since Gov cloud is just an older version of global. |
@spinkernel I have tested this locally, futzing the queries to force to use the alternative method to generate compatible file list JSON .. so far so good & no issues. The only concern however is - because there is no way to track changes with /delta - the only method is to walk all files and folders via query - which could either be time & processing sensitive. In the current code, still to do:
It would be great to get feedback on how this is performing for you as well - curious on how long it takes to generate |
@spinkernel The latest version of the PR also now correctly handles seeking all files:
So it would be great to get some reference from your experience. Your version should be |
Seems to be working....
|
@spinkernel I have also updated the |
Great, I just updated it after sending that. I'll update again. No method of downloading on demand? How would sharepoint sites work? I don't see anything int he config to access them. Normally there's some url that gets opened with window's onedrive app in order to do the sync. |
Not at the moment - see #757
Refer to https://github.com/abraunegg/onedrive/blob/master/docs/Office365.md (That .md file really should be renamed) The following I have confirmed as working:
However this is not working right now:
|
@spinkernel This should now handle remote deletes from OneDrive - thus should now completely support National Cloud Deployments. Please can you test this extensively with any usage scenarios you see yourself using to assist in shaking out any remaining issues. |
@spinkernel |
I've updated to the latest but I haven't done much testing, I had something come up that has been taking all my time. I'll play with it more this weekend. |
@abraunegg
sometimes when updating. Also seems like the way O365 vs Sharepoint Sites could be different? I don't have the "shared libraries" you talk about in your 365 instructions. On the windows client I would click a sync button on sharepoint site, and would get opened by the onedrive app: would there be a way to create a separate config for each "site" to sync using the url they generate? Not sure how I can help troubleshoot that. |
Also getting:
When uploading new files to a folder. |
@spinkernel The 'only' way to debug this further would be to look at a verbose debug log which show out what is going on. Have a look at this process: https://github.com/abraunegg/onedrive/wiki/Generate-debug-log-for-support See if you can generate the required debug log, look at the information it contains - then have a chat with your security team as to if these details can be sent / shared. 90% of the data is internal 'what is the application doing', but there are details like drive ID and the like as well. You could 'redact' those, but then all the correlation mapping in the debug log is lost. You could 'mask / substitute' the sensitive details which would be better than pure 'redaction' I am also OK with you contacting me off GitHub via email, and signing any sort of NDA or whatever with your organisation as well. |
@spinkernel Given the original issue of supporting the National Cloud instances is working, the PR as developed should be merged into master and any issues, like your seeing, tracked as separate items. |
I agree, it does work, we will need to track that sure. I have not had time to pull the log, i also have to get the OK from my IT guy to go forward. I can ping you directly. PM your direct contact so we can go from there. |
* Implement support for National cloud deployments as per https://docs.microsoft.com/en-us/graph/deployments
@spinkernel |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Is your feature request related to a problem? Please describe.
Greetings, attempting to use this tool with Gov Cloud (office365.us / microsoft.us)
When attempting to authenticate I get:
Describe the solution you'd like
Authentication to complete.
Describe alternatives you've considered
None
Additional context
None.
The text was updated successfully, but these errors were encountered: