Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting features from all the data (both train and text data) #2

Open
alenrooni opened this issue Feb 28, 2014 · 1 comment
Open

Selecting features from all the data (both train and text data) #2

alenrooni opened this issue Feb 28, 2014 · 1 comment

Comments

@alenrooni
Copy link

Hi,
I ran your program and found something that you may want to work on it ;)
when you are selecting the best features you should not look into your test data. It will look like your program is cheating :D
I did the same mistake once and i was very happy that my small program is beating all state of the art classification algorithms of the world.

Good Program though.
@abromberg
Copy link
Owner

Great point @alenrooni ! If you want to fix it, I'd be more than happy to merge a PR in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abromberg @alenrooni