Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Room non-existing joined #14

Open
wowawiwa opened this issue May 11, 2020 · 2 comments
Open

On Room non-existing joined #14

wowawiwa opened this issue May 11, 2020 · 2 comments

Comments

@wowawiwa
Copy link
Collaborator

wowawiwa commented May 11, 2020

Currently: It displays Loading.
Expected: Proceed as if the roomID hasn'nt been given.

Currently, there is no way for the FE to distinguish if the join-room request is taking time or if the room doesn't exist.
At best the BE would return an error status code on a request to join a non-existing room. Or it could send an event later.

@wowawiwa wowawiwa changed the title Error on joining a room which doesn't exist (BE) Handle Room doesn't exist when joining (BE) May 11, 2020
@abustany
Copy link
Owner

Yeah we clearly need a pattern here to deal with commands that can fail... Currently a command being "successful" just means it's been successfully received by the server, but not that it was successfully processed by the retro "object". The retro will currently just ignore invalid commands, but we need to be better at surfacing those errors. But then do we need to identify which command caused an error? If so do we need (optional) command IDs akin to the id field in JSON-RPC calls?

@wowawiwa wowawiwa added this to the Next milestone May 26, 2020
@wowawiwa wowawiwa changed the title Handle Room doesn't exist when joining (BE) On Room non-existing joined May 26, 2020
@wowawiwa
Copy link
Collaborator Author

wowawiwa commented Jun 4, 2020

Wouldn't it be okay to send room-not-found with the payload of the room when the client tries to connect to a non existing room?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants