ReportService - GetReportsByNextToken if nextToken is empty request first page #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en request the first page Currently there is GetReportsByNextToken to get the next page of reports, however, there is no (public method) way to retrieve the initial page of reports. This revision makes that if nextToken is empty the first page will be retrieved. Note: We can rename this method to: "GetReportsPage" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReportService - GetReportsByNextToken if nextToken is empty request first page
Currently, there is the
public GetReportsByNextTokenmethod so clients can call to get the next page of reports, this is an important method cause - unlike theReportService.GetReportsAsyncmethod which loops until reports are retrieved - this gives control to the user whether to continue asking for next page of reports or to stop.However, there is no (public method) way to retrieve the initial page of reports. This revision changes the code in
ReportService.GetReportsByNextTokenAsyncsuch that if the ParameterReportList.nextToken parameter is empty the first page will be retrieved.Note: We may want to rename this method to: "GetReportsPage" ?