From b7ae014db2a007a12d07bfc6efaf288fff482c77 Mon Sep 17 00:00:00 2001
From: Steve Samson <steve.samson@acceldata.io>
Date: Wed, 3 Jul 2024 03:22:46 -0400
Subject: [PATCH] Test Debug

---
 .../metastore/conf/TestMetastoreConf.java     | 33 ++++++++++++++++---
 1 file changed, 28 insertions(+), 5 deletions(-)

diff --git a/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/conf/TestMetastoreConf.java b/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/conf/TestMetastoreConf.java
index b5208c7fe75a9..7cd97cad4caa8 100644
--- a/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/conf/TestMetastoreConf.java
+++ b/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/conf/TestMetastoreConf.java
@@ -83,10 +83,13 @@ public void run() {
 
     }
   }
-  private void createConfFile(String fileName, boolean inConf, String envVar,
+  private String createConfFile(String fileName, boolean inConf, String envVar,
                               Map<String, String> properties) throws IOException {
     File tmpDir = new File(System.getProperty("java.io.tmpdir"));
     File dir = new File(tmpDir, randomFileName());
+    if(envVar.equals("HIVE_HOME")){
+      System.out.println("DBUG: writing to: " + dir.getAbsolutePath());
+    }
     Assume.assumeTrue(dir.mkdir());
     dir.deleteOnExit();
     System.setProperty(MetastoreConf.TEST_ENV_WORKAROUND + envVar, dir.getAbsolutePath());
@@ -98,19 +101,30 @@ private void createConfFile(String fileName, boolean inConf, String envVar,
     File confFile = new File(dir, fileName);
     confFile.deleteOnExit();
     FileWriter writer = new FileWriter(confFile);
+    StringBuilder sb = new StringBuilder("<configuration>\n");
     writer.write("<configuration>\n");
     for (Map.Entry<String, String> entry : properties.entrySet()) {
+      sb.append("  <property>\n");
       writer.write("  <property>\n");
       writer.write("    <name>");
+      sb.append("    <name>");
       writer.write(entry.getKey());
+      sb.append(entry.getKey());
       writer.write("</name>\n");
+      sb.append("</name>\n");
       writer.write("    <value>");
+      sb.append("    <value>");
       writer.write(entry.getValue());
+      sb.append(entry.getValue());
       writer.write("</value>\n");
+      sb.append("</value>\n");
       writer.write("  </property>\n");
+      sb.append("  </property>\n");
     }
     writer.write("</configuration>\n");
+    sb.append("</configuration>\n");
     writer.close();
+    return sb.toString();
   }
 
   private String randomFileName() {
@@ -210,11 +224,15 @@ public void readHiveSiteWithHiveConfDir() throws IOException {
 
   @Test
   public void readHiveSiteWithHiveHomeDir() throws IOException {
-    createConfFile("hive-site.xml", true, "HIVE_HOME", instaMap(
+    String confStr = createConfFile("hive-site.xml", true, "HIVE_HOME", instaMap(
         "test.bool", "false"
     ));
     conf = MetastoreConf.newMetastoreConf();
-    Assert.assertFalse(MetastoreConf.getBoolVar(conf, ConfVars.BOOLEAN_TEST_ENTRY));
+    String found = conf.get("test.bool");
+    System.out.println(String.format("DBUG: readHiveSiteWithHiveHomeDir : Found:%s, for key:'test.bool'", found));
+    boolean outcome = MetastoreConf.getBoolVar(conf, ConfVars.BOOLEAN_TEST_ENTRY);
+    System.out.println(String.format("DBUG: Check for Key:%s, Expected:%s in %s  Actual:%s", ConfVars.BOOLEAN_TEST_ENTRY,"false", confStr, outcome));
+    Assert.assertFalse(outcome);
   }
 
   @Test
@@ -229,11 +247,16 @@ public void readHiveMetastoreSiteWithHiveConfDir() throws IOException {
 
   @Test
   public void readHiveMetastoreSiteWithHiveHomeDir() throws IOException {
-    createConfFile("hivemetastore-site.xml", true, "HIVE_HOME", instaMap(
+    String confStr = createConfFile("hivemetastore-site.xml", true, "HIVE_HOME", instaMap(
         "test.bool", "false"
     ));
+
     conf = MetastoreConf.newMetastoreConf();
-    Assert.assertFalse(MetastoreConf.getBoolVar(conf, ConfVars.BOOLEAN_TEST_ENTRY));
+    String found = conf.get("test.bool");
+    System.out.println(String.format("DBUG: readHiveMetastoreSiteWithHiveHomeDir : Found:%s, for key:'test.bool'", found));
+    boolean outcome = MetastoreConf.getBoolVar(conf, ConfVars.BOOLEAN_TEST_ENTRY);
+    System.out.println(String.format("DBUG: Check for Key:%s, Expected:%s in %s Actual:%s", ConfVars.BOOLEAN_TEST_ENTRY,"false", confStr, outcome));
+    Assert.assertFalse(outcome);
   }
 
   @Test