Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shuffle functionality #738

Open
robbevp opened this issue Mar 23, 2022 · 1 comment
Open

Improve shuffle functionality #738

robbevp opened this issue Mar 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@robbevp
Copy link
Member

robbevp commented Mar 23, 2022

I'd like to improve our current shuffle functionality, to bring it more inline with how most media players work and how the android app works.

Our current behaviour:

  • Pressing shuffle is an action, with shuffles the playlist around.
  • There is no way to go back to the "ordered" playlist.

In most media players:

  • Pressing shuffle is a toggle, turning the shuffleMode off/on.
  • When shuffled is on, there is a second playlist is with a shuffled order that gets used to determine next/prev track. (Depending on the player, this new order might be shown).
  • When shuffle is off, the playlist always assumes the order in which the tracks were added.
  • Depending on the player adding new tracks to a shuffled playlist adds them at the end or at a random position.
@robbevp robbevp added the enhancement New feature or request label Mar 23, 2022
@robbevp robbevp added this to the later milestone Mar 23, 2022
@robbevp
Copy link
Member Author

robbevp commented Mar 23, 2022

I actually starting working on this, thinking it could be an easy thing to change, but due to our current implementation of the player store and component it became pretty tricky when trying to figure out all the mutations for deleting a track from the playlist, or adding (a) track(s) to it, since this would now have to mutate two arrays.

@chvp chvp removed this from the later milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants