Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdf transform: link with formatting do not get properly translated #470

Open
jeromesimeon opened this issue Oct 26, 2021 · 0 comments
Open
Assignees
Labels

Comments

@jeromesimeon
Copy link
Member

Bug Report 🐛

If a link contains formatted text (e.g., emphasized) it is sometimes not rendered into pdf.

Expected Behavior

Links should be properly rendered.

Current Behavior

Links are not always properly rendered.

Possible Solution

Render the links that are not properly rendered.

Steps to Reproduce

  1. Example CiceroMark:
    {
      "$class": "org.accordproject.commonmark.Document",
      "xmlns": "http://commonmark.org/xml/1.0",
      "nodes": [
          {
              "$class": "org.accordproject.commonmark.Link",
              "destination": "https://docusign.com",
              "title": "This link",
              "nodes": [
                  {
                      "$class": "org.accordproject.commonmark.Emph",
                      "nodes": [
                          {
                              "$class": "org.accordproject.commonmark.Text",
                              "text": "This link"
                          }
                      ]
                  }
              ]
          },
          {
              "$class": "org.accordproject.commonmark.Emph",
              "nodes": [
                  {
                      "$class": "org.accordproject.commonmark.Text",
                      "text": " is to DocuSign."
                  }
              ]
          }
      ]
    }
    
  2. Convert to pdf: markus transform --from commonmark --to pdf --input ./link.json --output test.pdf
  3. Attached is the pdf where the link is missing.

test.pdf

@jeromesimeon jeromesimeon self-assigned this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant