Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Lerna to npm workspaces #570

Merged
merged 12 commits into from
Sep 27, 2023
Merged

Migrate from Lerna to npm workspaces #570

merged 12 commits into from
Sep 27, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Sep 26, 2023

lerna publish is now creating errors with newer version of npm. This PR removes Lerna from this mono repo, replacing it with the built in npm --workspaces commands.

Lerna error:

ERR! bootstrap The "bootstrap" command was removed by default in v7, and is no longer maintained.

Changes

  • Remove lerna
  • Update scripts to use npm workspaces
  • Remove some dead package.json entries
  • Fix web pack config
  • Removed the dingus UI. This is(somewhat) superseded by https://playground.accordproject.org.

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Pull Request Test Coverage Report for Build 6316739684

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on ds-lerna-upgrade at 69.978%

Totals Coverage Status
Change from base Build 6302889854: 70.0%
Covered Lines: 2785
Relevant Lines: 3811

💛 - Coveralls

Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Dan Selman <[email protected]>
@dselman dselman merged commit dd9751c into main Sep 27, 2023
17 checks passed
@dselman dselman deleted the ds-lerna-upgrade branch September 27, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants