Updated merge of old repos with tests added #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The final log statement uses the segment ID which could be invalid because once the flushing_count is decremented the segment_destroy call could complete and destroy the actual segment.
This is not ideal there area couple of options 1) add a string helper function 2) just make the cap a printable string. I don't think there is much an issue doing this.
Declaring the start_index as volatile disables the optimization. Without it you get the following warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true on the 'while' condition
The old method had the inc/dec and destruction as separate functions
unlike the new method, using tbx_{obj}ref}.h, where they are combined.
these are now combined as a single unit.
It was creating issues compiling some executables. Nothing extra is being exposed.
This is only used by lio_warm. As a work around I added a hack function. Once another DS is implemented we can extrapoalte and make a proper API for warming.
The core tests were added below the API just exposing the high-level tests which are then called form the actual test
I have a very bad feeling all the lio_* executables need a similar patch
lio_read wasn't always returning the number of bytes actually read but instead the buffer size. lio_myopen_fn had a failure edge case not propagating an error. The fd was set to NULL properly but not the status.
|
This PR doesn't merge against master, @tacketar |
Everything compiles except the gridftp plugin. This does have the name-mangling changes applied. The plugin doesn't compile even from a fresh clone. There seem to be issues with finding the globus packages and also incorrect number of args.
I don't see how these FindGlobus*.cmake routines ever worked. Calling FindPackage(XxxYyy REQUIRED) checks for a XxxYyy_FOUND variable on return to determine success and NOT Xxx_Yyy_FOUND which which is what was set in both those routines. I made the minimal change of Xxx_Yyy_FOUND->XxxYyy_FOUND for both routines. The other library and include paths still have the name separation, Xxx_Yyy_*. This allows the packages to be be found and builds the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is massive and unwieldy pull request. Getting this merged in should get us back to making more manageable pull requests. This has a litany of changes: