Formatting changes #115
Merged
Formatting changes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ackintosh any feedback? |
|
Thank you for this PR, and I apologize for the delay! 🙏 I will have a look at this by this weekend. |
* Remove docblocks that are no longer needed As we have types already added to the code then the docblocks don't add anything and actually make it harder to maintain * Add CS formatting rules Make sure all classes are consistent by having a new line after the opening tag. At the minute there's a mixture of the two. Removed unused imports * Add phpunit cache to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove docblocks that are no longer needed
As we have types already added to the code
then the docblocks don't add anything
and actually make it harder to maintain
Add CS formatting rules
Make sure all classes are consistent
by having a new line after the opening tag.
At the minute there's a mixture of the two.
Removed unused imports
Add phpunit cache to gitignore