Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions to V4 #116

Merged
merged 1 commit into from
May 28, 2024

Conversation

maxbaldanza
Copy link
Contributor

@maxbaldanza maxbaldanza commented May 23, 2024

Node12 and Node16 are now
depreacted so updating to V4
github actions as that uses Node20

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20

Node12 and Node16 are now
depreacted so updating to V4
github actions as that uses Node20
@@ -14,6 +14,6 @@ jobs:

steps:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's intentional or not but this doesn't run on pull requests at the minute.

@coveralls
Copy link

Coverage Status

coverage: 91.479% (-1.2%) from 92.647%
when pulling ee6efa4 on maxbaldanza:use-v4-github-actions
into 911e2a8 on ackintosh:master.

@maxbaldanza
Copy link
Contributor Author

I don't think the CI failures are due to my changes as the checkout step seems to work ok but let me know if there's something I need to take a look at

Copy link
Owner

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Yes, you're right. It seems that uploading coverage results failed, so there is nothing to do in this PR regarding the CI failure.

@ackintosh ackintosh merged commit 72eae8b into ackintosh:master May 28, 2024
7 of 8 checks passed
@maxbaldanza maxbaldanza deleted the use-v4-github-actions branch May 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants