Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert changing actions to PRs #19

Open
3 tasks
diamondburned opened this issue Mar 8, 2024 · 0 comments
Open
3 tasks

Convert changing actions to PRs #19

diamondburned opened this issue Mar 8, 2024 · 0 comments

Comments

@diamondburned
Copy link
Member

We could use PRs to ensure that actions requesting to add and update packages can be verified to still build without actually deploying them to production. It also simplifies the actions a lot.

Plan:

  • Attempt to Nix build a Terraform plan. This ensures that we could fully validate that systems can be built.
    • Alternatively, do nix-build ./servers/*/ -A system. This saves us from having to work with
  • Create an action for just building that, triggered by making or modifying a PR.
    • We don't reuse the deploy action because there's no easy way to share build outputs without uploading them to a server.
  • Change existing add/update actions to create a PR instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant