Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meeting] Form meeting (Mar 25th) #20

Open
2 tasks
EthanThatOneKid opened this issue Mar 26, 2024 · 0 comments
Open
2 tasks

[Meeting] Form meeting (Mar 25th) #20

EthanThatOneKid opened this issue Mar 26, 2024 · 0 comments
Labels
meeting Meeting

Comments

@EthanThatOneKid
Copy link
Contributor

πŸ™‹ Participants

@acmcsufoss/form

πŸ“ Meeting location

Open Source Software team VC

πŸ—“οΈ Meeting date and time

Mar 25th, 2024 10:15 PM

⏱️ Estimated meeting duration

60 minutes

πŸ“‹ Meeting agenda

  • Welcome new and returning participants.

πŸš€ Meeting updates

Frontend

  • Figuring out how the draft store should work. Where does the state live? Variables internal to each editor component or externally and passed down into it? The "event listener back propagation" <=> "prop-drilling" technique is so crazy, so we need a custom, global store.
  • Universal store for to persistently (integrate "persistable" localStorage API with Svelte stores), reactively store the form drafts on the browser.
  • We need the value of our store to be a Map object, but to make the store reactive to changes, we must create a custom store that wraps the standard Svelte writable store since mutations to a Map object are not made using the = assignment operator.
  • The Alex (team store) and KJ (team bind) debate: KJ spontaneously "fixed" the binding technique we started with. Alex says "hold on it doesn't work with our components, redundant copy-pasted <input> elements. i think ik why it's working now.". KJ and Ethan are confused. If the binding technique is found to behave properly, it would be chosen over the store technique. Alex thinks this doesn't work. Is this the end of the binding technique? KJ says, "We just need to make sure the form value is being synced at the <form> level". KJ walks Alex through on how to reproduce their results.
  • @keillor and @AlexthePear join forces to pair program with the support of @dhnpx and @EthanThatOneKid to get the binding to maybe finally work once and for all!? Alex's mind is blown "This is some crazy gymnastics to get this to work; this feels very spaghetti.". Now that we have a proof-of-concept, Ethan can try to simplify it as best he can to de-spaghettify where possible. Alex and KJ to stress test their solution for bugs. Alex worries that jumping around to the store technique might be just as complicated if not worse than the binding solution. Ethan and Alex to work on store. Ethan, Alex, KJ to reconvene to double check on Thursday if we will become team store or team binding. Alex pushes acmcsufoss/form@a602b35.
  • Ethan to create a helper function for creating a blank question when adding a new question to the question list editor component.
  • @dhnpx suggests git reset --hard.

😸 Action items

Backend

  • Reimplement the Store interface using Drizzle and PostgreSQL.
  • Specifically for deterministic frontend testing, we can reimplement the Store interface again but with static sample data.

✨ Meeting wrap-up

  • Next meeting: In-person Thursday 4:00 PM meeting.
  • Adjournment time: 1:00 AM -> Node.js Documentary.

image

@EthanThatOneKid EthanThatOneKid added the meeting Meeting label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting Meeting
Projects
None yet
Development

No branches or pull requests

1 participant