From 9926d71a86693db9afde13cea9bb467d1690d140 Mon Sep 17 00:00:00 2001
From: tylerslaton <mtslaton1@gmail.com>
Date: Fri, 26 Jan 2024 12:48:56 -0500
Subject: [PATCH] address code review

Signed-off-by: tylerslaton <mtslaton1@gmail.com>
---
 .../computeclass/all-set/existing.yaml        | 21 ++++++++-----------
 .../quota/testdata/basic/expected.golden      |  2 +-
 .../compute-class-default/existing.yaml       |  6 +++---
 3 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/pkg/controller/appdefinition/testdata/computeclass/all-set/existing.yaml b/pkg/controller/appdefinition/testdata/computeclass/all-set/existing.yaml
index 1ab9b61a7..9d66b0fc2 100644
--- a/pkg/controller/appdefinition/testdata/computeclass/all-set/existing.yaml
+++ b/pkg/controller/appdefinition/testdata/computeclass/all-set/existing.yaml
@@ -9,15 +9,12 @@ memory:
   min: 50Mi
   max: 200Mi
   default: 100Mi
-  requestScaler: 0.5
-# affinity:
-#   nodeAffinity:
-#     requiredDuringSchedulingIgnoredDuringExecution:
-#       nodeSelectorTerms:
-#       - matchExpressions:
-#         - key: foo
-#           operator: In
-#           values:
-#           - bar
-supportedRegions:
-- local
\ No newline at end of file
+affinity:
+  nodeAffinity:
+    requiredDuringSchedulingIgnoredDuringExecution:
+      nodeSelectorTerms:
+      - matchExpressions:
+        - key: foo
+          operator: In
+          values:
+          - bar
diff --git a/pkg/controller/quota/testdata/basic/expected.golden b/pkg/controller/quota/testdata/basic/expected.golden
index 8f8bf90b4..35a38cea8 100644
--- a/pkg/controller/quota/testdata/basic/expected.golden
+++ b/pkg/controller/quota/testdata/basic/expected.golden
@@ -11,7 +11,7 @@ spec:
     apps: 0
     computeClasses:
       default-compute-class:
-        cpu: 250m
+        cpu: "0"
         memory: 1Gi
     containers: 1
     images: 0
diff --git a/pkg/controller/resolvedofferings/testdata/computeclass/compute-class-default/existing.yaml b/pkg/controller/resolvedofferings/testdata/computeclass/compute-class-default/existing.yaml
index 8d6c4d5f1..4f0e3b883 100644
--- a/pkg/controller/resolvedofferings/testdata/computeclass/compute-class-default/existing.yaml
+++ b/pkg/controller/resolvedofferings/testdata/computeclass/compute-class-default/existing.yaml
@@ -17,9 +17,9 @@ description: Simple description for a simple ComputeClass
 cpuScaler: 0.25
 default: true
 memory:
-  min: 100Mi # 1Mi
-  max: 200Mi # 2Mi
-  default: 100Mi # 1Mi
+  min: 100Mi # 100Mi
+  max: 200Mi # 200Mi
+  default: 100Mi # 100Mi
 affinity:
   nodeAffinity:
     requiredDuringSchedulingIgnoredDuringExecution: