From 62be11bb8b551d71b73baa7341ceef03750deda8 Mon Sep 17 00:00:00 2001
From: Daishan Peng <daishan@acorn.io>
Date: Sat, 4 Nov 2023 01:58:39 -0700
Subject: [PATCH] Remove duplicate endpoint, apply protocol

Signed-off-by: Daishan Peng <daishan@acorn.io>
---
 pkg/controller/appstatus/endpoints.go | 38 ++++++++++++++++++++-------
 1 file changed, 28 insertions(+), 10 deletions(-)

diff --git a/pkg/controller/appstatus/endpoints.go b/pkg/controller/appstatus/endpoints.go
index f48d537ff..62bc77edd 100644
--- a/pkg/controller/appstatus/endpoints.go
+++ b/pkg/controller/appstatus/endpoints.go
@@ -30,6 +30,7 @@ func serviceEndpoints(ctx context.Context, c kclient.Client, app *v1.AppInstance
 		return nil, err
 	}
 
+	endpointSet := map[string]v1.Endpoint{}
 	for _, service := range serviceList.Items {
 		containerName := service.Labels[labels.AcornContainerName]
 		if containerName == "" {
@@ -53,44 +54,57 @@ func serviceEndpoints(ctx context.Context, c kclient.Client, app *v1.AppInstance
 					portNum := port.Port
 					if len(ingress.Ports) > 0 {
 						for _, ingressPort := range ingress.Ports {
-							endpoints = append(endpoints, v1.Endpoint{
+							portProtocol := port.Protocol
+							if ingressPort.Protocol != "" {
+								portProtocol = ingressPort.Protocol
+							}
+							ep := v1.Endpoint{
 								Target:     containerName,
 								TargetPort: port.TargetPort.IntVal,
 								Address:    fmt.Sprintf("%s:%d", ingress.Hostname, ingressPort.Port),
-								Protocol:   protocol,
-							})
+								Protocol:   v1.Protocol(portProtocol),
+							}
+							endpointSet[endpointKey(ep)] = ep
 						}
 					} else {
-						endpoints = append(endpoints, v1.Endpoint{
+						ep := v1.Endpoint{
 							Target:     containerName,
 							TargetPort: port.TargetPort.IntVal,
 							Address:    fmt.Sprintf("%s:%d", ingress.Hostname, portNum),
 							Protocol:   protocol,
-						})
+						}
+						endpointSet[endpointKey(ep)] = ep
 					}
 				} else if ingress.IP != "" {
-					endpoints = append(endpoints, v1.Endpoint{
+					ep := v1.Endpoint{
 						Target:     containerName,
 						TargetPort: port.TargetPort.IntVal,
 						Address:    fmt.Sprintf("%s:%d", ingress.IP, port.Port),
 						Protocol:   protocol,
-					})
+					}
+					endpointSet[endpointKey(ep)] = ep
 				}
 			}
 
 			if len(service.Status.LoadBalancer.Ingress) == 0 {
-				endpoints = append(endpoints, v1.Endpoint{
+				ep := v1.Endpoint{
 					Target:     containerName,
 					TargetPort: port.TargetPort.IntVal,
 					Address:    fmt.Sprintf("<Pending Ingress>:%d", port.Port),
 					Protocol:   protocol,
 					Pending:    true,
-				})
+				}
+				endpointSet[endpointKey(ep)] = ep
 			}
 		}
 	}
 
-	return
+	result := make([]v1.Endpoint, 0, len(endpointSet))
+	for _, ep := range endpointSet {
+		result = append(result, ep)
+	}
+
+	return result, nil
 }
 
 func ingressEndpoints(ctx context.Context, c kclient.Client, app *v1.AppInstance) (endpoints []v1.Endpoint, _ error) {
@@ -204,3 +218,7 @@ func ingressTLSHosts(ctx context.Context, client kclient.Client, app *v1.AppInst
 
 	return ingressTLSHosts, nil
 }
+
+func endpointKey(ep v1.Endpoint) string {
+	return fmt.Sprintf("%v://%v", ep.Protocol, ep.Address)
+}