Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Improve error message presented when computeclass creation fails because of memory being present in resources/limits. #2405

Open
sangee2004 opened this issue Jan 10, 2024 · 0 comments
Labels
kind/bug Something isn't working
Milestone

Comments

@sangee2004
Copy link
Contributor

acorn version v0.10.0-rc2-9-g43dbcbf4+43dbcbf4

Steps to reproduce the problem:

  1. Try to create computeclass with memory present in resources/limits
kind: ClusterComputeClass
apiVersion: admin.acorn.io/v1
default: false
metadata:
  name: cc-res-inv
description: Large compute for linux on arm64
cpuScaler: 0.75
supportedRegions:
 - local
memory:
  default: 20M
  min: 10M
  max: 100M
resources:
  limits:
    memory: 50M
    gpu-vendor.example/example-gpu: 2
  requests:
    gpu-vendor.example/example-gpu: 2
  1. This fails as expected with following error message:
The ClusterComputeClass "cc-res-inv" is invalid: spec.resources.limits.memory: Invalid value: resource.Quantity{i:resource.int64Amount{value:50, scale:6}, d:resource.infDecAmount{Dec:(*inf.Dec)(nil)}, s:"50M", Format:"DecimalSI"}: Cannot specifiy spec.resources.limits.memory. Use explicit spec.cpuScaler and spec.memory instead

Expected Behavior:
Error message can be improved to be more readable in this case.

@sangee2004 sangee2004 added the kind/bug Something isn't working label Jan 10, 2024
@sangee2004 sangee2004 added this to the Backlog milestone Jan 10, 2024
@sangee2004 sangee2004 added the help wanted Extra attention is needed label Jan 10, 2024
@cjellick cjellick removed the help wanted Extra attention is needed label Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants