Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS module audit #158

Open
rlnorthcutt opened this issue Jul 31, 2019 · 5 comments
Open

PS module audit #158

rlnorthcutt opened this issue Jul 31, 2019 · 5 comments
Assignees
Labels

Comments

@rlnorthcutt
Copy link
Contributor

Mike Madison has done an audit of our old DF module list to see what they might want to pull into their distro. He highlighted a few modules that have weak/limited support that we should check out to see if we can replace them, remove them, or pull their functionality into a df_tool module:

  1. better_formats - this doesn't have a stable release and has been neglected. Suggested to look at allowed_formats as a possible replacement. We may want to create a patch for any additional features from better_formats.

  2. content_browser - I know that this is smortyware, and I am inclined to keep it. But, if this just provides some presets for entity_browser, maybe we should just have config? What else does this provide? Should we update and create a stable version?

  3. image_effects - How are we using this in DF now? Do we need it? I don't recall any SAs needing this kind of functionality, so maybe we just don't need it anymore? If so - could we just grab the one or two image style plugins and put them in a custom df_tools module?

  4. message & message_notify - Again, how are we using this in DF now? Do we really need it? Can we simplify or streamline things?

  5. replicate - This seems to be unmaintained and has an issue suggesting deprecation in favor of entity_clone. PS also suggests entity_clone. I think we need to test both and see if either has a better experience, otherwise we should move to a more supported module.

Source: https://docs.google.com/spreadsheets/d/1GUN-b_6k2iHtONh27nx7wv_hGvnoa0D2PGZQ5LCmP20/

@rlnorthcutt rlnorthcutt added this to the 19Q3 DF4 alpha4 milestone Aug 20, 2019
@kevinfunk kevinfunk self-assigned this Aug 20, 2019
@rlnorthcutt rlnorthcutt modified the milestones: 19Q3 DF4 alpha4, 19Q3 DF4 beta2 Oct 7, 2019
@rlnorthcutt rlnorthcutt modified the milestones: 4.0.0-beta2, 4.0.0-beta3 Oct 16, 2019
@saltednut saltednut removed this from the 4.0.0-beta3 milestone Feb 18, 2020
@kevinfunk
Copy link
Contributor

Entity Blocks looks like another module we might be able to remove.

@saltednut
Copy link
Contributor

Is it used by any 4.x Scenario?

@kevinfunk
Copy link
Contributor

I know it's not used in One. I don't think Gol or Default use it, but I'll check.

@kevinfunk
Copy link
Contributor

message & message_notify - Again, how are we using this in DF now? Do we really need it? Can we simplify or streamline things?

I think it is safe to remove them. They were require by df_tools_message and it was removed in 4.x.

@kevinfunk
Copy link
Contributor

Entity Blocks looks like another module we might be able to remove.

Entity Blocks is coming from Lightning Layout. We are patching it to provide UUID support. I'll test to see with the patch is needed for Default Content if someone would need to use Entity Blocks.

kevinfunk added a commit that referenced this issue Mar 2, 2020
kevinfunk added a commit that referenced this issue Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants