Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify rust-toolchain.toml path #47

Open
Svampen opened this issue Oct 19, 2024 · 1 comment
Open

Add option to specify rust-toolchain.toml path #47

Svampen opened this issue Oct 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Svampen
Copy link

Svampen commented Oct 19, 2024

Our rust code doesn't live in the root folder because the project contains both JS and Rust code, making it impossible for the action to pick up our rust-toolchain.toml file.
It would be good if one could specify the path to the rust-toolchain.toml file(s) and have that be used.

We had a issue today with rust 1.82.0 in regards to Fastly that made us having to pin 1.81.0 but we had to do it in our rust-toolchain.toml and in the github action. This proposed option would make it less likely that we would forget to unpin the version in both places.

@jonasbb
Copy link
Member

jonasbb commented Oct 20, 2024

That sounds reasonable. Instead of a separate value, I think this could piggyback of the cache-workspaces input. That input allows specifying multiple workspaces, which might not work too well with the current installation code.

@jonasbb jonasbb added the enhancement New feature or request label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants