fix issue 1743

sqle/driver/mysql/audit_test.go

@@ -129,7 +129,8 @@ func runDefaultRulesInspectCase(t *testing.T, desc string, i *MysqlDriverImpl, s
 		rulepkg.DMLCheckAlias:                               {},
 		rulepkg.DMLCheckAffectedRows:                        {},
 		rulepkg.DMLCheckSortColumnLength:                    {},
-		rulepkg.DDLCheckAllIndexNotNullConstraint:			 {},
+		rulepkg.DDLCheckAllIndexNotNullConstraint:           {},
+		rulepkg.DMLCheckAggregate:                           {},
 	}
 	for i := range rulepkg.RuleHandlers {
 		handler := rulepkg.RuleHandlers[i]
@@ -5330,7 +5331,6 @@ func TestDDLCheckAllIndexNotNullConstraint(t *testing.T) {
 	)
 }
 
-
 func TestDMLCheckSameTableJoinedMultipleTimes(t *testing.T) {
 	rule := rulepkg.RuleHandlerMap[rulepkg.DMLCheckSameTableJoinedMultipleTimes].Rule
 
@@ -5456,3 +5456,47 @@ func TestDMLCheckSameTableJoinedMultipleTimes(t *testing.T) {
 		newTestResult().add(driverV2.RuleLevelError, rulepkg.DMLCheckSameTableJoinedMultipleTimes, "表`exist_db`.`exist_tb_2`被连接多次"),
 	)
 }
+
+func TestDMLCheckAggregate(t *testing.T) {
+	rule := rulepkg.RuleHandlerMap[rulepkg.DMLCheckAggregate].Rule
+	runSingleRuleInspectCase(
+		rule,
+		t,
+		"",
+		DefaultMysqlInspect(),
+		`select avg(v1) from exist_tb_1 group by v2`,
+		newTestResult().addResult(rulepkg.DMLCheckAggregate),
+	)
+	runSingleRuleInspectCase(
+		rule,
+		t,
+		"",
+		DefaultMysqlInspect(),
+		`select v2 from exist_tb_1 group by v2 having count(1) > 1`,
+		newTestResult().addResult(rulepkg.DMLCheckAggregate),
+	)
+	runSingleRuleInspectCase(
+		rule,
+		t,
+		"",
+		DefaultMysqlInspect(),
+		`update exist_tb_1 set v1 = (select avg(v1) from exist_tb_2 group by v2 having count(1) > 1 limit 1)`,
+		newTestResult().addResult(rulepkg.DMLCheckAggregate),
+	)
+	runSingleRuleInspectCase(
+		rule,
+		t,
+		"success",
+		DefaultMysqlInspect(),
+		`update exist_tb_1 set v1 = (select v1 from exist_tb_2 limit 1)`,
+		newTestResult(),
+	)
+	runSingleRuleInspectCase(
+		rule,
+		t,
+		"success",
+		DefaultMysqlInspect(),
+		`select v1 from exist_tb_1`,
+		newTestResult(),
+	)
+}

sqle/driver/mysql/rule/rule.go

@@ -176,6 +176,7 @@ const (
 	DMLCheckUpdateOrDeleteHasWhere            = "dml_check_update_or_delete_has_where"
 	DMLCheckSortColumnLength                  = "dml_check_order_by_field_length"
 	DMLCheckSameTableJoinedMultipleTimes      = "dml_check_same_table_joined_multiple_times"
+	DMLCheckAggregate                         = "dml_check_aggregate"
 )
 
 // inspector config code
@@ -2082,6 +2083,18 @@ var RuleHandlers = []RuleHandler{
 		Message:      "表%v被连接多次",
 		Func:         checkSameTableJoinedMultipleTimes,
 	},
+	{
+		Rule: driverV2.Rule{
+			Name:       DMLCheckAggregate,
+			Desc:       "禁止使用聚合函数",
+			Annotation: "禁止使用SQL聚合函数是为了确保查询的简单性、高性能和数据一致性。",
+			Level:      driverV2.RuleLevelError,
+			Category:   RuleTypeDMLConvention,
+		},
+		AllowOffline: true,
+		Message:      "禁止使用聚合函数计算",
+		Func:         checkAggregateFunc,
+	},
 }
 
 func checkFieldNotNUllMustContainDefaultValue(input *RuleHandlerInput) error {
@@ -5909,7 +5922,7 @@ func getTableNameWithSchema(stmt *ast.TableName, c *session.Context) string {
 	} else {
 		tableWithSchema = fmt.Sprintf("`%s`.`%s`", stmt.Schema, stmt.Name)
 	}
-	
+
 	if c.IsLowerCaseTableName() {
 		tableWithSchema = strings.ToLower(tableWithSchema)
 	}
@@ -5919,7 +5932,7 @@ func getTableNameWithSchema(stmt *ast.TableName, c *session.Context) string {
 
 func checkSameTableJoinedMultipleTimes(input *RuleHandlerInput) error {
 	var repeatTables []string
-	
+
 	if _, ok := input.Node.(ast.DMLNode); ok {
 		selectVisitor := &util.SelectVisitor{}
 		input.Node.Accept(selectVisitor)
@@ -5973,3 +5986,23 @@ func checkAllIndexNotNullConstraint(input *RuleHandlerInput) error {
 	}
 	return nil
 }
+
+func checkAggregateFunc(input *RuleHandlerInput) error {
+	if _, ok := input.Node.(ast.DMLNode); ok {
+		selectVisitor := &util.SelectVisitor{}
+		input.Node.Accept(selectVisitor)
+		for _, selectNode := range selectVisitor.SelectList {
+			if selectNode.Having != nil {
+				addResult(input.Res, input.Rule, input.Rule.Name)
+				return nil
+			}
+			for _, field := range selectNode.Fields.Fields {
+				if _, ok := field.Expr.(*ast.AggregateFuncExpr);ok {
+					addResult(input.Res, input.Rule, input.Rule.Name)
+					return nil
+				}
+			}
+		}
+	}
+	return nil
+}