fix-issue1758: create audit plan failed #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
details: create audit plan failed due to audit plan name too long direct reason: The length of the jwt token exceeds the upper limit of varchar(255) defined in the data table, resulting in insert failure. deep reason: the length of apn is too long,resulting in the generated jwt token being too long. solution: Use MD5 to hash the name and apn that may be too long to make the name and apn for generating each token become fixed-length, thereby controlling the length of the token. @LinXiaoTao
If the value determines the apn calculated by MD5, it will cause the token that was not generated according to MD5 to be invalidated, so it is also allowed to resolve the apn and the apn in the URL all the time @LinXiaoTao
add comments for preprocessing code modifications of the auditplan token @LinXiaoTao
add test that compatible with older versions of tokens @LinXiaoTao
ColdWaterLW
approved these changes
Sep 7, 2023
|
Don't @ me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1758
Details: Create audit plan failed due to the audit plan name being too long.
Direct reason: The length of the jwt token exceeds the upper limit of varchar(255) defined in the data table, resulting in insert failure.
Deep reason: The length of apn(audit plan name) is too long, resulting in the generated jwt token being too long.
Solution: Use MD5 to hash the name and apn that may be too long to make the name and apn for generating each token become fixed-length, thereby controlling the length of the token.
@LinXiaoTao