From 5e7fa34aa1f5b103e78c9150cef505b2b3e2af58 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Wed, 24 Apr 2024 09:21:22 -0400 Subject: [PATCH 1/2] ci: do not fail fast on the rails testing matrix --- .github/workflows/ruby.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 7ae6364..371ef46 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -20,6 +20,7 @@ jobs: build: runs-on: ubuntu-latest strategy: + fail-fast: false matrix: # | rails | rails EOL | ruby EOL | min ruby| max | # | ----- | ---------+| --------+| --------|---- | From 808659bceb0eb6f45ee3196f583f238065c8050c Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Wed, 24 Apr 2024 09:22:00 -0400 Subject: [PATCH 2/2] test: pin sqlite3 to < 2.0 for now because the Rails adapter requires `~> 1.4` through v7.1.3.2 we can loosen this for later versions of Rails that contain rails/rails#51592 and any future releases of 7.1 that contain rails/rails#51636 --- Gemfile | 2 +- gemfiles/rails_6.0.gemfile | 2 +- gemfiles/rails_6.1.gemfile | 2 +- gemfiles/rails_7.0.gemfile | 2 +- gemfiles/rails_7.1.gemfile | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index 6368533..dc504bd 100644 --- a/Gemfile +++ b/Gemfile @@ -12,7 +12,7 @@ platforms :jruby do end platforms :ruby do - gem 'sqlite3', '~> 1.4.0' + gem 'sqlite3', '~> 1.4', '< 2.0' # can allow 2.0 once Rails's sqlite adapter allows it end gem 'activerecord', '>= 5.0.0' diff --git a/gemfiles/rails_6.0.gemfile b/gemfiles/rails_6.0.gemfile index ca9bd6b..7771155 100644 --- a/gemfiles/rails_6.0.gemfile +++ b/gemfiles/rails_6.0.gemfile @@ -11,7 +11,7 @@ platform :jruby do end platform :ruby do - gem 'sqlite3' + gem 'sqlite3', '~> 1.4', '< 2.0' # can allow 2.0 once Rails's sqlite adapter allows it end gemspec :path => '../' diff --git a/gemfiles/rails_6.1.gemfile b/gemfiles/rails_6.1.gemfile index 1a6f8b2..8d4e71e 100644 --- a/gemfiles/rails_6.1.gemfile +++ b/gemfiles/rails_6.1.gemfile @@ -11,7 +11,7 @@ platform :jruby do end platform :ruby do - gem 'sqlite3' + gem 'sqlite3', '~> 1.4', '< 2.0' # can allow 2.0 once Rails's sqlite adapter allows it end gemspec :path => '../' diff --git a/gemfiles/rails_7.0.gemfile b/gemfiles/rails_7.0.gemfile index b78051a..ce67e67 100644 --- a/gemfiles/rails_7.0.gemfile +++ b/gemfiles/rails_7.0.gemfile @@ -11,7 +11,7 @@ platform :jruby do end platform :ruby do - gem 'sqlite3' + gem 'sqlite3', '~> 1.4', '< 2.0' # can allow 2.0 once Rails's sqlite adapter allows it end gemspec :path => '../' diff --git a/gemfiles/rails_7.1.gemfile b/gemfiles/rails_7.1.gemfile index 97bd7c1..d70255e 100644 --- a/gemfiles/rails_7.1.gemfile +++ b/gemfiles/rails_7.1.gemfile @@ -11,7 +11,7 @@ platform :jruby do end platform :ruby do - gem 'sqlite3' + gem 'sqlite3', '~> 1.4', '< 2.0' # can allow 2.0 once Rails's sqlite adapter allows it end gemspec :path => '../'