From 5d67e963d58499f402cd09c7d4ab68be6dee9b6d Mon Sep 17 00:00:00 2001 From: ohbarye Date: Tue, 20 Aug 2024 22:48:44 +0900 Subject: [PATCH 1/3] Run test against Rails 7.2 --- .github/workflows/ruby.yml | 10 +++++++++- gemfiles/rails_7.2.gemfile | 17 +++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 gemfiles/rails_7.2.gemfile diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 371ef46..b30ff39 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -31,8 +31,13 @@ jobs: # | 6.1 | | | 2.5 | | # | 7.0 | | | 2.7 | | # | 7.1 | | | 2.7 | | + # | 7.2 | | | 3.1 | | ruby: ['3.0', '3.1', '3.2', '3.3'] - gemfile: ['gemfiles/rails_6.1.gemfile', 'gemfiles/rails_7.0.gemfile', 'gemfiles/rails_7.1.gemfile'] + gemfile: + - 'gemfiles/rails_6.1.gemfile' + - 'gemfiles/rails_7.0.gemfile' + - 'gemfiles/rails_7.1.gemfile' + - 'gemfiles/rails_7.2.gemfile' include: - ruby: '2.4' gemfile: 'gemfiles/rails_5.0.gemfile' @@ -42,6 +47,9 @@ jobs: gemfile: 'gemfiles/rails_5.2.gemfile' - ruby: '2.7' gemfile: 'gemfiles/rails_6.0.gemfile' + exclude: + - ruby: '3.0' + gemfile: 'gemfiles/rails_7.2.gemfile' env: BUNDLE_GEMFILE: ${{ matrix.gemfile }} name: Ruby ${{ matrix.ruby }}, ${{ matrix.gemfile }} diff --git a/gemfiles/rails_7.2.gemfile b/gemfiles/rails_7.2.gemfile new file mode 100644 index 0000000..fd6478a --- /dev/null +++ b/gemfiles/rails_7.2.gemfile @@ -0,0 +1,17 @@ +source 'http://rubygems.org/' + +gem 'activerecord', '~> 7.2.0' +gem 'rspec', '~> 3.9' +gem 'rake', '~> 13.0' +gem 'json' +gem 'test-unit' + +platform :jruby do + gem 'activerecord-jdbcsqlite3-adapter', '>= 1.3.6' +end + +platform :ruby do + gem 'sqlite3', '~> 1.4', '< 2.0' # can allow 2.0 once Rails's sqlite adapter allows it +end + +gemspec :path => '../' From ff12a14e9b92c19b7b85519b966c6ef323981787 Mon Sep 17 00:00:00 2001 From: ohbarye Date: Tue, 20 Aug 2024 22:55:52 +0900 Subject: [PATCH 2/3] Add EOL info https://endoflife.date/rails https://endoflife.date/ruby --- .github/workflows/ruby.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index b30ff39..d069809 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -27,11 +27,11 @@ jobs: # | 5.0 | 6/2020 | 3/2020 | 2.2 | 2.4 | # | 5.1 | 6/2021 | 3/2021 | 2.2 | 2.5 | # | 5.2 | 6/2022 | 3/2022 | 2.2 | 2.6 | - # | 6.0 | 6/2023? | 3/3023?| 2.5 | 2.7 | - # | 6.1 | | | 2.5 | | - # | 7.0 | | | 2.7 | | - # | 7.1 | | | 2.7 | | - # | 7.2 | | | 3.1 | | + # | 6.0 | 6/2023 | 3/2023 | 2.5 | 2.7 | + # | 6.1 | 10/2024 | | 2.5 | | + # | 7.0 | 4/2025 | | 2.7 | | + # | 7.1 | 10/2025 | | 2.7 | | + # | 7.2 | 8/2026 | | 3.1 | | ruby: ['3.0', '3.1', '3.2', '3.3'] gemfile: - 'gemfiles/rails_6.1.gemfile' From ca3af92296c35e0af865d6bf1804e7d022098a53 Mon Sep 17 00:00:00 2001 From: ohbarye Date: Tue, 20 Aug 2024 22:56:50 +0900 Subject: [PATCH 3/3] Add /gemfiles/vendor/ to .gitignore It's needed to run `BUNDLE_GEMFILE=gemfiles/activerecord_7_2.gemfile bundle` to debug test failures but it creates files under `gemfiles/vendor`. So I decided to let it ignore them. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9492e33..88273be 100644 --- a/.gitignore +++ b/.gitignore @@ -11,4 +11,5 @@ pkg rdoc vendor/bundle gemfiles/.bundle +gemfiles/vendor gemfiles/*.lock