UI-0 - (UKS-5248) handle unexpected values in filter objects #47
Conversation
The else condition was causing the widget to be removed to not be included in the migrated content. so when the content got passed later on to the `removewidget` function it was incomplete leading to an erroneous result
There was a problem hiding this comment.
Thanks for the PR @ibolari42.
Besides the comments below, it seems that the two commits are orthogonal. Could you do separate PRs for each of them to keep changes atomic ?
| errorReport.pages[sectionKey].widgets[`All widgets in ${pageName}`] = { | ||
| widgetName: "All widgets", | ||
| error, | ||
| }; |
There was a problem hiding this comment.
This is a bit of a workaround.
I would prefer to introduce an error at the root of DashboardErrorReport and at the root of each page if necessary, in a preliminary PR.
| pageKey: string; | ||
| pageName: string; |
There was a problem hiding this comment.
Following the same idea, I would make those optional, as it is not needed for dashboard filters.
improvement to comments Co-authored-by: Antoine Tissier <[email protected]>
I'll get these seperated, Initiallly bound them together to make it easy for the people who needed the changes to download the branch before it was officially merged |
|
i'll close this request and creeate a new branch to keep changes atomic |
ibolari42
deleted the
ibo/UKS-5248-handle-unexpected-values-in-filter-objects
branch
This PR adds a function that checks the filters provided in each dashboard for non-string elements and removes then as the only expected elements in the filter are mdx strings.