Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

Use of Acts::UnitConstants in DD4hep plugins #1

Open
wdconinc opened this issue May 27, 2022 · 1 comment
Open

Use of Acts::UnitConstants in DD4hep plugins #1

wdconinc opened this issue May 27, 2022 · 1 comment

Comments

@wdconinc
Copy link

wdconinc commented May 27, 2022

In our (pre-19.1) DD4hep plugins, we use constructs such as the following:

    Acts::ActsExtension* beamPipeExtension = new Acts::ActsExtension();
    beamPipeExtension->addType("beampipe", "layer");
    beamPipeExtension->addValue(0.001 * Acts::UnitConstants::mm, "r_min", "envelope");
    beamPipeExtension->addValue(0.001 * Acts::UnitConstants::mm, "r_max", "envelope");
    beamPipeExtension->addValue(0.001 * Acts::UnitConstants::mm, "z_min", "envelope");
    beamPipeExtension->addValue(0.001 * Acts::UnitConstants::mm, "z_max", "envelope");
    central_det.addExtension<Acts::ActsExtension>(beamPipeExtension);

This seems to become impossible with the separate plugin (I admit this is a bit of a trivial example, since Acts::UnitConstants::mm == 1). Is there a plan to support units in this separated plugin?

@wdconinc
Copy link
Author

The reason for these particular addValue statements is a different story. They originate in exactly overlapping sensor and envelope surfaces that were an issue probably around about the Acts 8.03 days...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant