Bug: _acts_dfelibs_version unset in CMakeLists.txt

[wdconinc]

The CMake variable _acts_dfelibs_version is used in the find_package call but is not set to any value. The minimum version of dfelibs is likely the released version in the ACTS fork of dfelibs, but this released version does not include that same release version in the CMake config, so find_package would not recognize it as such.

Resolving this likely requires two step:

• a new release of acts-project/dfelibs with a corrected CMakeLists.txt,
• requiring that new release as the minimum dfelibs version in the CMakeLists.txt here.

Alternatively a comment in CMakeLists.txt with a statement why no minimum version is defined, but which one effectively applies.

[andiwand]

@fredevb @asalzburger is this something we lost in the CMake refactor when getting traccc/detray in as dependencies?

[wdconinc]

Related to this, the target that is used in e.g. Examples/Io/Csv/CMakeLists.txt is dfelibs, while the target exposed by an external install is dfelibs::dfelibs, in a namespace.

[wdconinc]

Other location where dfelibs is linked is in

acts/Examples/Framework/CMakeLists.txt

Line 36 in ca69799

PRIVATE dfelibs)

From what I can tell, that's independent of the csv example.

[wdconinc]

The instance in the framework example is necessary due to use of dfelibs in the sequence:

acts/Examples/Framework/src/Framework/Sequencer.cpp

Lines 53 to 54 in ca69799

	#include <dfe/dfe_io_dsv.hpp>
	#include <dfe/dfe_namedtuple.hpp>

[github-actions]

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.