Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address casting from unsigned to signed types across the codebase #3913

Closed
coderabbitai bot opened this issue Nov 27, 2024 · 0 comments · Fixed by #3932
Closed

Address casting from unsigned to signed types across the codebase #3913

coderabbitai bot opened this issue Nov 27, 2024 · 0 comments · Fixed by #3932
Assignees
@AJPfleger

Comments

@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2024

Casting from unsigned to signed types may lead to data loss or unexpected behavior if values exceed the range of the signed type. It is recommended to use std::ptrdiff_t or remain within unsigned arithmetic.

Pull Request: #3615
Comment: #3615 (comment)

Requested by @AJPfleger.
@AJPfleger AJPfleger mentioned this issue Dec 2, 2024
Merged
@AJPfleger AJPfleger linked a pull request Dec 2, 2024 that will close this issue
fix: remove narrowing conversion from std::size_t to int #3932
Merged
@kodiakhq kodiakhq bot closed this as completed in #3932 Dec 5, 2024
kodiakhq bot pushed a commit that referenced this issue Dec 5, 2024
@AJPfleger
fix: remove narrowing conversion from std::size_t to int (#3932)
4b27593 
I went through the cases, where we did `cast<int>` from `std::size_t` and implemented solutions to avoid this.

closes:
- #3913

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **Bug Fixes**
	- Improved type safety in various algorithms by changing loop index types from `int` to `std::size_t`.
	- Enhanced clarity in boundary condition checks within algorithms.

- **Documentation**
	- Corrected comments for clarity in the `DigitizationAlgorithm` class.

- **Chores**
	- Streamlined conditional logic in the `IndexedGridFiller` and `RefittingAlgorithm` classes for better readability and maintenance.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AJPfleger AJPfleger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove narrowing conversion from std::size_t to int AJPfleger/acts
1 participant
@AJPfleger