fix: oneAPI 2025 Fixes, main branch (2024.12.04.)

[krasznaa]

This is a twin of #3846. Unfortunately between that PR going in and v38.0.0 being made, some more errors of the same kind went in. This is meant to fix those.

--- END COMMIT MESSAGE ---

@paulgessinger, could we add a CI build with the latest clang version? That would pick up on these issues as well. We don't need oneAPI itself for catching these. 🤔

Summary by CodeRabbit

• Bug Fixes
  • Simplified method invocation syntax by removing the template keyword from allocateCalibrated and allocateCalibrated_impl calls, enhancing readability without altering functionality.
• Tests
  • Updated test cases to reflect the syntax change in method calls while preserving existing validation logic and error handling.

[coderabbitai]

Walkthrough

Changes made to the MultiTrajectory class and related files involve the removal of the template keyword from method calls, specifically in allocateCalibrated and allocateCalibrated_impl. This adjustment simplifies the syntax for invoking these methods across multiple overloads and related concepts. The modifications are consistent in MultiTrajectory, MutableMultiTrajectoryBackend, and MultiTrajectoryTestsCommon, ensuring clarity without altering functionality or control flow.

Changes

File Path	Change Summary
Core/include/Acts/EventData/MultiTrajectory.hpp	Removed template keyword from allocateCalibrated method calls, simplifying method invocation syntax.
Core/include/Acts/EventData/MultiTrajectoryBackendConcept.hpp	Removed template keyword from allocateCalibrated_impl method calls within MutableMultiTrajectoryBackend.
Core/include/Acts/EventData/detail/MultiTrajectoryTestsCommon.hpp	Removed template keyword from allocateCalibrated method calls in MultiTrajectoryTestsCommon, maintaining error handling.

Possibly related PRs

• ci: Add LCG 106a job #3918: The changes in this PR are unrelated to the modifications in the MultiTrajectory class, as they focus on CI/CD job configurations rather than code changes in the relevant classes or methods.

Suggested labels

automerge

Suggested reviewers

• AJPfleger

In code we refine, with changes so bright,
The template we banish, to simplify right.
Methods now clearer, in MultiTrajectory flow,
With syntax more friendly, our code starts to glow!
A journey of tidying, a path we embrace,
In the realm of the code, we find our true grace! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d806df0 and 0f4d888.

📒 Files selected for processing (3)

• Core/include/Acts/EventData/MultiTrajectory.hpp (2 hunks)
• Core/include/Acts/EventData/MultiTrajectoryBackendConcept.hpp (1 hunks)
• Core/include/Acts/EventData/detail/MultiTrajectoryTestsCommon.hpp (2 hunks)

🧰 Additional context used

📓 Learnings (1)

Core/include/Acts/EventData/MultiTrajectory.hpp (1)

Learnt from: paulgessinger
PR: acts-project/acts#3907
File: Core/include/Acts/EventData/VectorMultiTrajectory.hpp:349-351
Timestamp: 2024-11-26T10:57:04.925Z
Learning: In `VectorMultiTrajectory` class within `Core/include/Acts/EventData/VectorMultiTrajectory.hpp`, the initialization of `m_meas` and `m_measCov` is ensured by the rest of the interface.

🔇 Additional comments (5)

Core/include/Acts/EventData/MultiTrajectoryBackendConcept.hpp (1)

134-140: Approve these changes, I do!

Simplified the syntax has become, yet the same functionality remains. Template parameter deduction, handle this well it does. Cleaner and more maintainable, the code now is.

Core/include/Acts/EventData/MultiTrajectory.hpp (2)

699-699: Hmm, good this change is!

Consistent with the concept changes, this modification is. Proper parameter forwarding, maintained it has been.

---

708-708: Wise this change is, approve it I do!

In harmony with other changes, this modification is. Type safety, preserved it remains.

Core/include/Acts/EventData/detail/MultiTrajectoryTestsCommon.hpp (2)

1228-1228: Strong with the Force, this test case is!

Properly verifies the initialization functionality, it does. Good coverage, provided it has.

---

1242-1252: Well tested, the error paths are!

Proper validation of dimension constraints, this test provides. The dark side of invalid dimensions, caught it will be.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

📊: Physics performance monitoring for 4a9c80f

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[AJPfleger]

looks, basically the same as in the last one.

Having this in the CI might be useful. Do we need a full build for this? Ideally we could combine it with testing, but this problem we would already see at compile time, no?

[krasznaa]

Adding a Clang build would of course increase the CPU time of the CI. 🤔

At the same time see acts-project/machines#129 for that discussion. 😉

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
47.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[acts-project-service]

🔴 Athena integration test results [3d58bca]

Build job with this PR failed!

Please investigate the build job for the pipeline!