Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PitchYIN::calculatePitch reads off end of buffer #4

Open
FigBug opened this issue Jan 4, 2023 · 1 comment
Open

PitchYIN::calculatePitch reads off end of buffer #4

FigBug opened this issue Jan 4, 2023 · 1 comment

Comments

@FigBug
Copy link

FigBug commented Jan 4, 2023

delta = inputData[j] - inputData[j + tau];

j + tau > yin.getNumSamples() results in illegal memory access.
@adamski
Copy link
Owner

adamski commented Jan 26, 2023

Thanks, this library is in dire need of tidying up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamski @FigBug