Skip to content

Commit

Permalink
Merge pull request #429 from adeekshith/issue/428/build-errors
Browse files Browse the repository at this point in the history
Fix build errors for Android Studio Ladybug and fix Github CI
  • Loading branch information
adeekshith authored Oct 3, 2024
2 parents 2b97dca + df1c419 commit a2cfefa
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4

- name: Setup JDK
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
java-version: 11
java-version: '17'
distribution: 'zulu'

- name: Make gradlew executable
run: chmod +x ./gradlew
Expand All @@ -29,7 +30,7 @@ jobs:
shell: bash

- name: Upload Default Apk
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
id: upload
with:
name: PR-${{ github.event.number }}
Expand All @@ -45,7 +46,7 @@ jobs:
shell: bash

- name: Upload GooglePlay Apk
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
id: upload-googpe-play
with:
name: PR-${{ github.event.number }}-googleplay
Expand Down
3 changes: 3 additions & 0 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ android {
sourceCompatibility JavaVersion.VERSION_17
targetCompatibility JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = '17'
}
buildFeatures {
viewBinding = true
dataBinding = true
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
ext.kotlin_version = '1.9.20'
ext.kotlin_version = '1.9.21'
repositories {
google()
mavenCentral()
Expand Down

0 comments on commit a2cfefa

Please sign in to comment.