Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting store to false prevents logging #59

Open
nertzy opened this issue Mar 30, 2020 · 0 comments
Open

Setting store to false prevents logging #59

nertzy opened this issue Mar 30, 2020 · 0 comments
Assignees

Comments

@nertzy
Copy link

nertzy commented Mar 30, 2020

What did you do?

Set Sniffer.store = false

What did you expect to happen?

I expected Sniffer.data not to get populated, but I expected the logging to still occur.

What actually happened?

When store was set to false, logging did not occur.

Additional context

It seems like the middleware implementation of logging does not get called if store is disabled.

Environment

Ruby Version:
2.7

Framework Version (Rails, whatever):
Rails 6.0.2.2

Sniffer Version:
0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants