-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Free Throws, Blocks and Personal Fouls #12
Comments
No particular season they were emitted. At the beginning, I just wanted to get more of the basic features before adding other ones. Adding more features definitely does provide more information, it would create vectors of high dimensions which generally does make it a bit harder for the models to learn, so I'm not sure if a stat like minutes played would help that much. Although I could be wrong and like you mentioned, if you're seeing a slight performance boost, it could be worth it. |
The increase is very slight like 0.3% average increase in accuracy. It's small but consistent in that increase. |
Harder in the sense that increasing the number of features generally increases the number of training samples you may need to get a sufficiently trained model. https://en.wikipedia.org/wiki/Curse_of_dimensionality |
I noticed that free throws, blocks and personal fouls are not gathered by getSeasonData().
I'm not 100% familiar with the algorithm yet but I figured I'd add them to the list and see what happens. I am curious though why these were emitted from the start and I figured you guys might have a reason.
On another note much of the missing columns like TOV, Opp., ORB, MP and others have been added to sports-reference, I'm working on importing the data into the CSVs and I am seeing a slight accuracy boost.
The text was updated successfully, but these errors were encountered: