Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2022 Revamp & 2020 issues #18

Open
lightningcookies opened this issue Mar 13, 2022 · 1 comment
Open

2022 Revamp & 2020 issues #18

lightningcookies opened this issue Mar 13, 2022 · 1 comment

Comments

@lightningcookies
Copy link

Hey, I'm new to ML, trying to get my feet wet here. Can we get this updated to at least skip 2020(no tournament)? The program won't run without 2020 data.
I have formatted the College Basketball Reference data for 2021 and 2022 and would love to share if we can get this to work again :)

This project is awesome! I'd love to help make it better

@adeshpande3
Copy link
Owner

adeshpande3 commented Mar 13, 2022

Thanks for calling this out! Totally forgot that 2020 would mess things up (realizing the code could be written a bit better 😅 ). Remembering how this program works, I think we'd need to do the following

  1. Upload the CSV data from the new Kaggle year https://www.kaggle.com/c/mens-march-mania-2022/data
  2. Upload the formatted College Basketball Reference data like you mentioned. 🙏 ty for doing that
  3. Make sure that 2020 doesn't impact our ability to run the program. What's the error that you're getting when you run? Thinking of 2 options
    • Just remove 2020 from the processing altogether. Some sort of if statement and removing the data from Kaggle CSVs. Downside here is that we'd lose the regular season game info which still would be valuable.
    • Adding some sort of dummy data to replace the values for tournamentSeed, checkConferenceChamp, checkConferenceTourneyChamp. Maybe just make it so that everyone missed the tourney? Since it would apply to everyone that year, I think that should be fine?

I'm a bit pressed on time today, but if you submit a PR for any/all of the above (and I definitely might be missing something so lmk), I'd be more than happy to review and get over the line.

Happy Selection Sunday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants