Literal function name call fails

[BobBolch]

When the function name in a function call is a literal, the call fails.

ftest
2 - say 'SUBSTR'('NOK',2,2)
Error 43 running ftest, line 2: Routine not found
Ready(20043); T=0.01/0.02 10:05:04

t ftest exec

/* */
say 'SUBSTR'('NOK',2,2)

Ready; T=0.01/0.01 10:05:12

---

On real REXX:
ftest
OK
Ready; T=0.01/0.01 10:05:41

[mgrossmann]

strange behavior if I have added a working call in front of the non working.
then all went fine:

/* REXX */                 
PARSE VERSION LANG VER     
                           
SAY "### "LANG" "VER" ###" 
SAY " "                             

SAY SUBSTR('NOK',2,2)  
SAY 'SUBSTR'('NOK',2,2) 

Ready;                               
tst61                                
### CMS bREXX 0.9.12 Mar 15 2021 ### 
                                     
OK                                   
OK                                   

I would guess the compiler.
I'll have to take a closer look tonight.

[BobBolch]

t test exec /* */ say 'SUBSTR'('NOK',2) Ready; T=0.01/0.01 13:02:06 test 2 *-* say 'SUBSTR'('NOK',2) Error 43 running test, line 2: Routine not found Ready(20043); T=0.01/0.01 13:02:11

…

On Fri, Mar 19, 2021 at 8:59 AM Mike Großmann ***@***.***> wrote: Did some more testing Ready; tst61 ### REXX370 3.40 17 Jan 1984 ### OK 8 +++ SAY 'SSUBSTR'('NOK',2,2) Error 43 running TST61 EXEC, line 8: Routine not found Ready(20043); Ready; tst61 ### REXX370 4.02 01 Dec 1998 ### OK OK Ready; READY tst61 ### REXX370 3.48 01 May 1992 ### OK OK READY — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARUFCBL42ANKGJXRYL3FJPTTENDCZANCNFSM4VRD4HCA> .

[BobBolch]

bobtest OK Ready; q cmslevel VM/SP Release 5, Service Level 521 Ready; t bobtest exec /* REXX */ /*-------------------------------------------------------------------- */ say 'SUBSTR'('NOK',2,2) Ready;

…

On Fri, Mar 19, 2021 at 9:08 AM Mike Großmann ***@***.***> wrote: What I wanted to show with my tests is that it also leads to an error under VM/SP. Only in later REXX/370 versions the behavior was changed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARUFCBOJBKWEDAUQKJYGAALTENEDRANCNFSM4VRD4HCA> .

[mgrossmann]

Sorry Bob,

you are right, I had a typo in my first test. :(
Have deleted my older comments.

/MIkeG

/* REXX */                
PARSE VERSION LANG VER    
                          
SAY "### "LANG" "VER" ###"
SAY " "                   
                          
SAY SUBSTR('NOK',2,2)     
SAY 'SUBSTR'('NOK',2,2)

Ready;                          
tst61                           
### REXX370 3.40 17 Jan 1984 ###
                                
OK                              
OK                              
Ready;     

[RossPatterson]

I can reproduce this with Bob Bolch's 2021-01-02 test case (above) on original bREXX at the current source level (2.1.9+). I'll work on a fix and then port it here.

[RossPatterson]

This is not going to be as easy to fix as I had hoped. The code in compile.c:_AddLabel() that decides which type of routine to execute does not contemplate having two routine with the same name. In its mind, internal routines override built-in functions of the same name, which override external routines of the same name. I'm putting this issue back in the inactive list for now.

[RossPatterson]

Note: The CALL 'routine_name' instruction behaves exactly the same way.