Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system is outdated and needs upgrading #84

Open
RossPatterson opened this issue Oct 23, 2024 · 4 comments
Open

Build system is outdated and needs upgrading #84

RossPatterson opened this issue Oct 23, 2024 · 4 comments
Assignees
Labels
bug Something isn't working fixed in next release

Comments

@RossPatterson
Copy link
Collaborator

RossPatterson commented Oct 23, 2024

There are several problems with the current build system. I'm aware of the following, and will fix them, and will update this issue if I discover any more.

  1. The GitHub actions/checkout@v1, actions/checkout@v1 , actions/[email protected], and actions/[email protected] actions used by .github/workflows/build.yml use outdated versions of node.js (ref. https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/, https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/).

  2. The GitHub actions/[email protected] action used by .github/workflows/build.yml use a set-output command that will be disabled "soon" (ref. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/).

  3. The GCCLIB version used by cmsbuild.sh is version 1.0.0, which doesn't include changes that were delivered in VM/370 Community Edition 1.1.1 (GCCLIB 1.0.1).

  4. The SYSPROFB EXEC installed on the vm370 Docker image does not work with BREXX 1.0.1 and GCCLIB 1.0.1 (as delivered in VM/CE 1.1.1).

  5. The VM/370 version in the Docker image does not have the NUCXTEXT command that is needed to load BREXX 1.0.1 and newer.

@RossPatterson RossPatterson added the bug Something isn't working label Oct 23, 2024
@RossPatterson RossPatterson self-assigned this Oct 23, 2024
@RossPatterson
Copy link
Collaborator Author

  1. The GitHub actions/checkout@v1, actions/checkout@v1 , actions/[email protected], and actions/[email protected] actions used by .github/workflows/build.yml use outdated versions of node.js (ref. https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/, https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/).

Fixed in bREXX 1.1.0 beta 01.

@RossPatterson
Copy link
Collaborator Author

RossPatterson commented Nov 3, 2024

3. The GCCLIB version used by cmsbuild.sh is version 1.0.0, which doesn't include changes that were delivered in VM/370 Community Edition 1.1.1 (GCCLIB 1.0.1)
4. The SYSPROFB EXEC installed on the vm370 Docker image does not work with BREXX 1.0.1 and GCCLIB 1.0.1 (as delivered in VM/CE 1.1.1).
5. The VM/370 version in the Docker image does not have the NUCXTEXT command that is needed to load BREXX 1.0.1 and newer.

Fixed in bREXX 1.1.0 beta 01, by upgrading the Docker image to VM/370 Community Edition v1.1.2.

@RossPatterson
Copy link
Collaborator Author

2. The GitHub actions/[email protected] action used by .github/workflows/build.yml use a set-output command that will be disabled "soon" (ref. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/).

GitHub has retracted the "soon", and has no target EOL for this after all (ref. https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/)

@RossPatterson
Copy link
Collaborator Author

Additional items, all fixed in bREXX 1.1.0 beta 01:

  1. The BRXASM, BRXCOMP, and BRXCOMPD tools produce bare TEXT files, which don't show their provenance. I've added a TXTDATE EXEC which uses the CMS VMFDATE command to annotate the TEXT files in the same manner as VMFASM.
  2. The BRXGEN tool can be simplified by using &ERROR &EXIT &RETCODE instead of checking the return code of almost every command it issues.
  3. The cmsbuild.sh script has a hard-coded list of files to move to the T-disk. The usual way to handle this is to prove a CMS EXEC-style file listing them all. I've added BRXTOOLS EXEC to do that.
  4. Rather than writing an extensive set of instructions for installing the beta of bREXX 1.1.0, I've written a new BRXLOAD EXEC tool to load the build from either the tape or VMARC files, and to move the files to their various destinations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next release
Projects
None yet
Development

No branches or pull requests

1 participant