Incorrect event translation for FreeSwitch Ringing

[dwilkie]

According to the Rayo spec here:
http://xmpp.org/extensions/inbox/rayo.html#def-ringing the ringing event is "Indication that an outbound call has begun ringing, or accepted by the remote party."

In the FreeSwitch translator this is translated here https://github.com/adhearsion/punchblock/blob/develop/lib/punchblock/translator/freeswitch/call.rb#L74 as register_handler :es, :event_name => 'CHANNEL_STATE', [:[], :channel_call_state] => 'RINGING'

However this guard does not specify the call_direction being outbound so it is triggered on an incoming dial.

Furthermore for and outbound call the CHANNEL_STATE event does not give a channel_call_state of RINGING

This event translation definitely needs to have a guard on call_direction => outbound to comply with the spec, but I believe it also needs to have a guard on channel_call_state => EARLY as well.

See also this gist for the events triggered when an outbound dial is performed:
https://gist.github.com/dwilkie/5530574

[benlangfeld]

Closing this following the logic in #201