Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements #1

Open
emiliyank opened this issue May 12, 2024 · 0 comments
Open

Minor improvements #1

emiliyank opened this issue May 12, 2024 · 0 comments

Comments

@emiliyank
Copy link

Hi Aditya Pratap Bhuyan!
Great job with this repo and the instructions to it. Here are just few suggestions how you can improve it:

  1. According to the readme the mysql password should be password while in the mysql-app-deployment.yaml file it is actually set to root. So in this file line 25 should be changed to value: password
  2. In the README at the last kubectl command is missing the apply - it should be kubectl apply -f deployments/mysql-app-service.yaml. And also the filename has typo in the repository, it is mysql-aap-service.yaml while it actually should be mysql-app-service.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant