Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources/iso_parameterDirectionCode.yml naming #102

Closed
jwaspin opened this issue Dec 11, 2024 · 3 comments
Closed

Fix resources/iso_parameterDirectionCode.yml naming #102

jwaspin opened this issue Dec 11, 2024 · 3 comments

Comments

@jwaspin
Copy link
Contributor

jwaspin commented Dec 11, 2024

The resources/iso_parameterDirectionCode.yml codelistName needs to match the filename

@hmaier-fws
Copy link
Contributor

@jwaspin this isn't how most of the codelists are named. There's also an open issue to update the contribution guidelines, indicating that "Code" suffix should be removed (#44).

Unless there is some other reason to make the change, we should just leave the existing name as "iso_parameterDirection". (or to be consistent, include "Code" on all of the ISO codelist filenames)

@jwaspin
Copy link
Contributor Author

jwaspin commented Dec 12, 2024

@hmaier-fws I'll update the file to remove "Code" as a suffix. Wasn't sure which way to go on this.

@jwaspin
Copy link
Contributor Author

jwaspin commented Dec 17, 2024

Closed by #99

@jwaspin jwaspin closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants