New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n JSON example abandoned - should be fixed to show proper usage #388

Open

Ronald-Diemicke opened this issue Jan 5, 2023 · 1 comment

Assignees

Labels

Ronald-Diemicke commented Jan 5, 2023

Expected Behaviour

There should be an example on how to use a .json for i18n

Actual Behaviour

https://github.com/adobe/aem-guides-wknd/blob/main/ui.apps/src/main/content/jcr_root/apps/wknd/i18n/fr.json exists as an example, but appears to go unused as it isn't referenced anywhere.

Reproduce Scenario (including but not limited to)

Looking at the live instance, https://wknd.site/fr/fr.html , this never appears.

Steps to Reproduce

Look at the code for a reference to fr.json or at https://wknd.site/fr/fr.html - neither uses the translation available in https://github.com/adobe/aem-guides-wknd/blob/main/ui.apps/src/main/content/jcr_root/apps/wknd/i18n/fr.json

Platform and Version

Current

Sample Code that illustrates the problem

https://github.com/adobe/aem-guides-wknd/blob/main/ui.apps/src/main/content/jcr_root/apps/wknd/i18n/fr.json

Logs taken while reproducing problem

SachinMali self-assigned this

SachinMali added the enhancement label

Contributor

SachinMali commented Jan 18, 2023

The fr.json acts as a dictionary and is mainly used for presenting component UI in different languages, please see details here

However, for the French version of WKND site (multilingual websites), the steps outlined here would be needed.

I am flagging this as an enhancement and will look into prioritization.

Meanwhile for more info on Translation please see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment