Number.isNaN and Number.parseInt breaks app in IE

[gwak]

Hi,

I don't think you should use Number.isNaN and Number.parseInt in the lt-body component:
https://github.com/offirgolan/ember-light-table/blob/master/addon/components/lt-body.js
as it breaks apps in IE. I've tested IE 11.
I think you should use a polyfill or isNaN, and parseInt directly.

Thanks,
Camille

[gwak]

Well actually it can be fixed by adding the following in ember-cli-build.js:

"ember-cli-babel": {
  includePolyfill: true
}

[alexander-alvarez]

We took the approach of doing alphasights/ember-scrollable#69 in ember-scrollable. It's pretty trivial to add if someone wants to bother with it and maybe save someone else headache.

A more involved but proper solution would be to leverage the new targets in 2.12+

[buschtoens]

A more involved but proper solution would be to leverage the new targets in 2.12+

Turns out targets don't currently include polyfills, but only manage transpilation. 🙁

https://embercommunity.slack.com/archives/C045BNHAP/p1498049676269826

[alexander-alvarez]

thanks for the investigation @buschtoens
It seems like the logical next steps for targets, I clearly overstated what targets can do (for now).
I updated #430 do you think that's the right approach?

[buschtoens]

I do have a spike to make ember-cli-babel build a more minimal polyfill

Until we get this functionality, a conditional polyfill in index.js seems like a sensible solution.